061f6baaf1
## 背景 / 需求 新增「微信登录」链路:用户用微信授权登录 App。openid 已绑账号即直接登入; 未绑则走「绑手机号」建号,并处理「手机号已被别的账号占用」的冲突(M2), 以及绑微信后展示昵称/头像的替换策略(M3 §10)。 关键取舍:微信登录**不套用**钱包提现里 bind-wechat 的「撞号即 409」逻辑 ——登录场景 openid 命中就应登入,不能因撞号把用户挡在门外。 ## 改动概览:新增 5 个端点(前缀 `/api/v1/auth`) | 方法 | 路径 | 作用 | |---|---|---| | POST | `/wechat-login` | code→openid。命中已绑用户→直接登入;未命中→签发 `bind_ticket`,返回 `need_bind_phone`(**此刻不建号**);未配 APP_ID/SECRET→503 | | POST | `/wechat/bind-phone/sms` | 持 `bind_ticket` + 手机号 + 短信码绑号 | | POST | `/wechat/bind-phone/jverify` | 持 `bind_ticket` + 极光本机号一键取号绑号 | | POST | `/wechat/conflict/continue` | 占用冲突·继续绑定=**登录老账号**(老号没绑微信则把 openid 绑上;已绑别的微信则只登入、丢弃本次 openid) | | POST | `/wechat/conflict/rebind` | 占用冲突·换绑=**单事务**注销老账号 X(腾号)+ 用该号重建新账号 Y + 写换绑台账;受 30 天限制 | 绑号两条取号路径(sms / jverify)尾段共用 `_finish_wechat_bind`: 手机号未注册→建微信账号(channel=wechat,昵称头像取微信)登入; 已被占用→返回 `phone_occupied`(带占用账号昵称/头像/注册时间/`has_wechat`、 `conflict_ticket`、`rebind_available`、`rebind_blocked_days`),交前端冲突页。 冲突页三选一,后端提供 continue / rebind 两个动作(「取消」为前端本地行为)。 ## 关键设计 **两种短时令牌(`core/security.py`,复用 `JWT_SECRET_KEY`,靠 `typ` 区分):** - `bind_ticket`(typ=wechat_bind,sub=openid,附微信昵称/头像,TTL 10min): openid 未命中时下发,覆盖「授权→输手机号→收码→验码」整个绑定流程。 - `conflict_ticket`(typ=wechat_conflict):比 bind_ticket **多编码已验证的手机号**; 换绑 / 继续绑定只认票里的 phone,堵住「拿别人手机号去夺号」的接管漏洞。 **30 天换绑限制:** 新增台账表 `phone_rebind_log`(手机号级、渠道无关), 记录「腾号重建」这一破坏性事件,靠 `rebound_at` 算窗口; 阈值走配置 `PHONE_REBIND_LIMIT_DAYS`。命中限制的换绑请求返回 409。 **M3 §10 昵称/头像替换:** 绑微信默认用微信昵称/头像替换展示, 抽成共享 helper,登录绑号路径与钱包绑微信路径两处共用 (故 `wallet.py`、`tests/test_withdraw.py` 一并有改动)。 --------- Co-authored-by: guke <guke@autohome.com.cn> Reviewed-on: #139
199 lines
8.5 KiB
Python
199 lines
8.5 KiB
Python
"""微信登录 M1 测试:bind_ticket 令牌、wechat-login(openid 命中/未命中)、
|
|
bind-phone(建号/占用/令牌过期)。
|
|
|
|
沿用 tests/test_auth.py 风格:HTTP 走 client fixture;微信 code→openid 用 monkeypatch
|
|
拦掉(conftest 里 WECHAT_APP_ID/SECRET 是 dummy,不真连微信);短信走 SMS_MOCK(任意 6 位通过)。
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from app.api.v1 import auth
|
|
from app.core import security
|
|
from app.integrations import wxpay
|
|
|
|
|
|
def _fake_userinfo(openid: str, nickname: str | None = "微信昵称", avatar: str | None = "http://x/a.png"):
|
|
"""返回一个可传给 monkeypatch 的假 code_to_userinfo(忽略 code,固定返回给定 openid)。"""
|
|
def _f(code: str) -> dict:
|
|
return {"openid": openid, "nickname": nickname, "avatar_url": avatar, "raw": {}}
|
|
return _f
|
|
|
|
|
|
# ===== Task 1: bind_ticket 令牌 =====
|
|
|
|
def test_bind_ticket_roundtrip() -> None:
|
|
token = security.create_bind_ticket(openid="oid1", wechat_nickname="昵", wechat_avatar_url="http://a")
|
|
claims = security.decode_bind_ticket(token)
|
|
assert claims["openid"] == "oid1"
|
|
assert claims["wnk"] == "昵"
|
|
assert claims["wav"] == "http://a"
|
|
|
|
|
|
def test_bind_ticket_wrong_type_rejected() -> None:
|
|
# 用 access token 冒充 bind_ticket → TokenError(typ 不匹配)
|
|
access, _ = security.create_token(user_id=1, token_type="access")
|
|
with pytest.raises(security.TokenError):
|
|
security.decode_bind_ticket(access)
|
|
|
|
|
|
def test_bind_ticket_expired_rejected(monkeypatch) -> None:
|
|
monkeypatch.setattr(security.settings, "WECHAT_BIND_TICKET_EXPIRE_MINUTES", -1)
|
|
token = security.create_bind_ticket(openid="oid", wechat_nickname=None, wechat_avatar_url=None)
|
|
with pytest.raises(security.TokenError):
|
|
security.decode_bind_ticket(token)
|
|
|
|
|
|
# ===== Task 2: wechat-login =====
|
|
|
|
def test_wechat_login_new_openid_returns_bind_ticket(client, monkeypatch) -> None:
|
|
monkeypatch.setattr(wxpay, "code_to_userinfo", _fake_userinfo("openid_new_1", "小明", "http://x/m.png"))
|
|
r = client.post("/api/v1/auth/wechat-login", json={"code": "wxcode1", "device_id": "devA"})
|
|
assert r.status_code == 200, r.text
|
|
body = r.json()
|
|
assert body["status"] == "need_bind_phone"
|
|
assert body["bind_ticket"]
|
|
assert body["wechat_nickname"] == "小明"
|
|
assert body["wechat_avatar_url"] == "http://x/m.png"
|
|
assert body["token"] is None
|
|
|
|
|
|
def test_wechat_login_invalid_code_returns_400(client, monkeypatch) -> None:
|
|
def _raise(code: str) -> dict:
|
|
raise ValueError("微信授权失败: invalid code")
|
|
monkeypatch.setattr(wxpay, "code_to_userinfo", _raise)
|
|
r = client.post("/api/v1/auth/wechat-login", json={"code": "bad", "device_id": "devA"})
|
|
assert r.status_code == 400, r.text
|
|
|
|
|
|
# ===== Task 3: bind-phone/sms =====
|
|
|
|
def test_wechat_bind_sms_creates_account_then_openid_logs_in(client, monkeypatch) -> None:
|
|
"""未占用 → 建微信账号(channel=wechat,昵称头像取微信);再次同 openid 登录 → 直接登入同一账号。"""
|
|
monkeypatch.setattr(wxpay, "code_to_userinfo", _fake_userinfo("openid_flow_2", "阿花", "http://x/h.png"))
|
|
phone = "13900139002"
|
|
|
|
# 1) 微信登录 → 未命中 → 拿 ticket
|
|
r = client.post("/api/v1/auth/wechat-login", json={"code": "c1", "device_id": "devB"})
|
|
ticket = r.json()["bind_ticket"]
|
|
assert ticket
|
|
|
|
# 2) 短信绑号(SMS_MOCK:任意 6 位通过)→ 建号 + 登入
|
|
r = client.post(
|
|
"/api/v1/auth/wechat/bind-phone/sms",
|
|
json={"bind_ticket": ticket, "phone": phone, "code": "123456", "device_id": "devB"},
|
|
)
|
|
assert r.status_code == 200, r.text
|
|
body = r.json()
|
|
assert body["status"] == "logged_in"
|
|
user = body["token"]["user"]
|
|
assert user["phone"] == phone
|
|
assert user["register_channel"] == "wechat"
|
|
assert user["nickname"] == "阿花"
|
|
assert user["avatar_url"] == "http://x/h.png"
|
|
uid = user["id"]
|
|
|
|
# 3) 再次微信登录(同 openid)→ 命中 → 直接登入同一账号
|
|
r = client.post("/api/v1/auth/wechat-login", json={"code": "c2", "device_id": "devB"})
|
|
assert r.status_code == 200, r.text
|
|
body = r.json()
|
|
assert body["status"] == "logged_in"
|
|
assert body["token"]["user"]["id"] == uid
|
|
|
|
|
|
def test_wechat_bind_sms_phone_occupied(client, monkeypatch) -> None:
|
|
"""手机号已被其他账号占用 → 返回 phone_occupied + 原账号信息(不建号)。"""
|
|
phone = "13900139003"
|
|
# 先用普通短信登录占用该手机号(register_channel=sms)
|
|
assert client.post("/api/v1/auth/sms/send", json={"phone": phone}).status_code == 200
|
|
r = client.post("/api/v1/auth/sms/login", json={"phone": phone, "code": "123456"})
|
|
assert r.status_code == 200, r.text
|
|
occupied_nickname = r.json()["user"]["nickname"]
|
|
|
|
# 微信登录(新 openid)→ 未命中 → ticket
|
|
monkeypatch.setattr(wxpay, "code_to_userinfo", _fake_userinfo("openid_occ_3"))
|
|
ticket = client.post(
|
|
"/api/v1/auth/wechat-login", json={"code": "c", "device_id": "devC"}
|
|
).json()["bind_ticket"]
|
|
|
|
# 绑同一手机号 → 占用
|
|
r = client.post(
|
|
"/api/v1/auth/wechat/bind-phone/sms",
|
|
json={"bind_ticket": ticket, "phone": phone, "code": "123456", "device_id": "devC"},
|
|
)
|
|
assert r.status_code == 200, r.text
|
|
body = r.json()
|
|
assert body["status"] == "phone_occupied"
|
|
assert body["token"] is None
|
|
assert body["occupied_account"]["nickname"] == occupied_nickname
|
|
assert body["occupied_account"]["avatar_url"] is None # 短信注册账号无头像 → 序列化为 null
|
|
assert body["occupied_account"]["created_at"]
|
|
|
|
|
|
def test_wechat_bind_sms_expired_ticket_returns_401(client, monkeypatch) -> None:
|
|
"""过期 bind_ticket → 401。"""
|
|
monkeypatch.setattr(security.settings, "WECHAT_BIND_TICKET_EXPIRE_MINUTES", -1)
|
|
expired = security.create_bind_ticket(openid="openid_exp", wechat_nickname="x", wechat_avatar_url=None)
|
|
r = client.post(
|
|
"/api/v1/auth/wechat/bind-phone/sms",
|
|
json={"bind_ticket": expired, "phone": "13900139009", "code": "123456", "device_id": "devD"},
|
|
)
|
|
assert r.status_code == 401, r.text
|
|
|
|
|
|
# ===== Task 4: bind-phone/jverify =====
|
|
|
|
def test_wechat_bind_jverify_creates_account(client, monkeypatch) -> None:
|
|
"""本机号(极光)绑定路径:verify_and_get_phone 拦掉,未占用 → 建号登入。"""
|
|
monkeypatch.setattr(wxpay, "code_to_userinfo", _fake_userinfo("openid_jv_5", "极光用户", None))
|
|
phone = "13900139005"
|
|
# 极光 loginToken→手机号 在 auth 模块命名空间打桩(auth.py 顶部 from ...jiguang import verify_and_get_phone)
|
|
monkeypatch.setattr(auth, "verify_and_get_phone", lambda token: phone)
|
|
|
|
ticket = client.post(
|
|
"/api/v1/auth/wechat-login", json={"code": "c", "device_id": "devE"}
|
|
).json()["bind_ticket"]
|
|
|
|
r = client.post(
|
|
"/api/v1/auth/wechat/bind-phone/jverify",
|
|
json={"bind_ticket": ticket, "login_token": "jgtoken", "device_id": "devE"},
|
|
)
|
|
assert r.status_code == 200, r.text
|
|
body = r.json()
|
|
assert body["status"] == "logged_in"
|
|
user = body["token"]["user"]
|
|
assert user["phone"] == phone
|
|
assert user["register_channel"] == "wechat"
|
|
assert user["nickname"] == "极光用户"
|
|
# 微信 userinfo 隐私脱敏 avatar=None → 头像为空(客户端兜底默认头像)
|
|
assert user["avatar_url"] is None
|
|
|
|
|
|
def test_wechat_bind_jverify_expired_ticket_returns_401(client, monkeypatch) -> None:
|
|
"""过期 bind_ticket → 401(极光绑号路径,decode 先于极光核验)。"""
|
|
monkeypatch.setattr(security.settings, "WECHAT_BIND_TICKET_EXPIRE_MINUTES", -1)
|
|
expired = security.create_bind_ticket(openid="openid_jv_exp", wechat_nickname="x", wechat_avatar_url=None)
|
|
r = client.post(
|
|
"/api/v1/auth/wechat/bind-phone/jverify",
|
|
json={"bind_ticket": expired, "login_token": "jgtoken", "device_id": "devE"},
|
|
)
|
|
assert r.status_code == 401, r.text
|
|
|
|
|
|
def test_wechat_bind_jverify_jiguang_error_returns_502(client, monkeypatch) -> None:
|
|
"""极光核验失败(JiguangError)→ 502。"""
|
|
monkeypatch.setattr(wxpay, "code_to_userinfo", _fake_userinfo("openid_jv_err"))
|
|
|
|
def _raise(token: str) -> str:
|
|
raise auth.JiguangError("mock jg failure")
|
|
|
|
monkeypatch.setattr(auth, "verify_and_get_phone", _raise)
|
|
ticket = client.post(
|
|
"/api/v1/auth/wechat-login", json={"code": "c", "device_id": "devE"}
|
|
).json()["bind_ticket"]
|
|
r = client.post(
|
|
"/api/v1/auth/wechat/bind-phone/jverify",
|
|
json={"bind_ticket": ticket, "login_token": "badtoken", "device_id": "devE"},
|
|
)
|
|
assert r.status_code == 502, r.text
|